Support for invoke local #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schickling
reviewed
May 23, 2017
src/index.ts
Outdated
| @@ -90,6 +118,14 @@ class ServerlessPlugin { | |||
| // Remove temp build folder | |||
| fs.removeSync(path.join(this.originalServicePath, buildFolder)) | |||
| } | |||
|
|
|||
| async cleanup(): Promise<void> { | |||
There was a problem hiding this comment.
Could we somehow avoid that redundancy as the same code is also part of the previous function?
There was a problem hiding this comment.
I think we can, since the after function actually uses originalServicePath, I think I can run the cleanup steps after everything in that function.
|
Would you mind adding some docs to the readme about this feature? |
|
@schickling can you tag a release for this change and publish to npm? What kind of docs are you looking for? The current state of |
|
Done! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the lifecycle hooks to make
sls invoke local -f <funcName>work.This fixes #8